Why is the setInterval not working

[RohitNz 7]

In the past I have used fibaro.sleep.  As I am migrating from HC2 to HC3, I have started using setInterval.  People seem to insist it is better, even though it destroys the readability of the code.  I am finding that it doesn't always work.  Sometimes it does not wait at all.

 

Here Loop_Secs is 15, and it shows that in the log.  Sometimes it works for two iterations and then just does not wait.  At other times, it does not wait at all.  While I was building it up and Main was empty, it was whizzing so fast, I could not get in from the browser and had to restart the HC.  What am I missing ?

 

Please login or register to see this code.

 

Edited May 10, 2023 by RohitNz

[jgab 1,954]

2 hours ago, RohitNz said:

In the past I have used fibaro.sleep.  As I am migrating from HC2 to HC3, I have started using setInterval.  People seem to insist it is better, even though it destroys the readability of the code.  I am finding that it doesn't always work.  Sometimes it does not wait at all.

 

Here Loop_Secs is 15, and it shows that in the log.  Sometimes it works for two iterations and then just does not wait.  At other times, it does not wait at all.  While I was building it up and Main was empty, it was whizzing so fast, I could not get in from the browser and had to restart the HC.  What am I missing ?

 

Please login or register to see this code.

 

setInterval takes a function and an integer for the time in ms.

In your case you provide a "function call" as the first argument. 

self.loop => <function>

self:loop() => nil, as the result of invoking self:loop() is nil because the function does not return any value...

You will get exactly one iteration, and at the first setInterval this will crash as the setInterval don't get the first argument expected.

 

Please login or register to see this code.

In this case you need to wrap the self:Loop() in an anonymous functions as self:Loop() is a short for self.Loop(self) and setTimeout don't let you pass arguments to the provided function.

You could also write it (better)

Please login or register to see this code.

 

[RohitNz 7]

1 hour ago, jgab said:

setInterval takes a function and an integer for the time in ms.

In your case you provide a "function call" as the first argument. 

self.loop => <function>

self:loop() => nil, as the result of invoking self:loop() is nil because the function does not return any value...

You will get exactly one iteration, and at the first setInterval this will crash as the setInterval don't get the first argument expected.

 

Please login or register to see this code.

In this case you need to wrap the self:Loop() in an anonymous functions as self:Loop() is a short for self.Loop(self) and setTimeout don't let you pass arguments to the provided function.

You could also write it (better)

Please login or register to see this code.

 

I would have got there faster if it had given me an error in the log when it crashed. 

[jgab 1,954]

1 hour ago, RohitNz said:

I would have got there faster if it had given me an error in the log when it crashed. 

to that I agree