Jump to content

Welcome to Smart Home Forum by FIBARO

Dear Guest,

 

as you can notice parts of Smart Home Forum by FIBARO is not available for you. You have to register in order to view all content and post in our community. Don't worry! Registration is a simple free process that requires minimal information for you to sign up. Become a part of of Smart Home Forum by FIBARO by creating an account.

 

As a member you can:

  •     Start new topics and reply to others
  •     Follow topics and users to get email updates
  •     Get your own profile page and make new friends
  •     Send personal messages
  •     ... and learn a lot about our system!

 

Regards,

Smart Home Forum by FIBARO Team


  • 0

First Script - what am I doing wrong?


darren-mc

Question

OK this is my first script which is a global on/off for house lights...depending on the weather..can some please tell me what I am doing wrong?

--[[

%% autostart

%% properties

%% globals

--]]

local AfterSunrise = 25

if (( fibaro:getValue(3, "WeatherConditionConverted") == "rain" )

or

( fibaro:getValue(3, "WeatherConditionConverted") == "cloudy" )

or

( fibaro:getValue(3, "WeatherConditionConverted") == "snow" ))

then

local BeforeSunset = 40

else

local BeforeSunset = 25

end

while true do

if (os.date("%H:%M", os.time()+BeforeSunset*60) >= fibaro:getValue(1, "sunsetHour"))

or (os.date("%H:%M", os.time()-AfterSunrise*60) < fibaro:getValue(1, "sunriseHour"))

then

fibaro:setGlobal("HouseLightsOn", "Active");

fibaro:call(2, "sendEmail", "House Lights On", "House Lights On");

else

fibaro:setGlobal("HouseLightsOn", "Inactive");

fibaro:call(2, "sendEmail", "House Lights Off", "House Lights Off");

end

fibaro:sleep(60*1000);

end

Link to comment
Share on other sites

3 answers to this question

Recommended Posts

  • 0

the way you have declared the local BeforeSunset it will go out of scope at the end of the if block

as we do not have global variables (yet) you could just get rid of the local keyword in the declarations or declare it as a local outside the if block

not looked at your other logic but that should allow you to test

Link to comment
Share on other sites

  • 0

This could be added to the luascheduler.

How well does the weather work to predict need for early / late lights on off

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...