First Script - what am I doing wrong?

[darren-mc 11]

OK this is my first script which is a global on/off for house lights...depending on the weather..can some please tell me what I am doing wrong?

--[[

%% autostart

%% properties

%% globals

--]]

local AfterSunrise = 25

if (( fibaro:getValue(3, "WeatherConditionConverted") == "rain" )

or

( fibaro:getValue(3, "WeatherConditionConverted") == "cloudy" )

or

( fibaro:getValue(3, "WeatherConditionConverted") == "snow" ))

then

local BeforeSunset = 40

else

local BeforeSunset = 25

end

while true do

if (os.date("%H:%M", os.time()+BeforeSunset*60) >= fibaro:getValue(1, "sunsetHour"))

or (os.date("%H:%M", os.time()-AfterSunrise*60) < fibaro:getValue(1, "sunriseHour"))

then

fibaro:setGlobal("HouseLightsOn", "Active");

fibaro:call(2, "sendEmail", "House Lights On", "House Lights On");

else

fibaro:setGlobal("HouseLightsOn", "Inactive");

fibaro:call(2, "sendEmail", "House Lights Off", "House Lights Off");

end

fibaro:sleep(60*1000);

end

[robmac 173]

the way you have declared the local BeforeSunset it will go out of scope at the end of the if block

as we do not have global variables (yet) you could just get rid of the local keyword in the declarations or declare it as a local outside the if block

not looked at your other logic but that should allow you to test

[darren-mc 11]

Ah..magic thanks for that..I was wondering if it would work like that.

[robmac 173]

This could be added to the luascheduler.

How well does the weather work to predict need for early / late lights on off