Help with LUA

[Lauri 6]

Hello, can you help me to find a problem here.

What is should do: It shold calculate

target2 - outTemp > hysteresis and then decide wether it needs to rise temperature or lower it. If rise, then it has to add to valve (roller shutter module) position 1% and wait for 10sec, if needed then open more 1% and so on.

What it actually does:

Everything is OK, but opening and closing the valve is not 1% and 10sec interval instead it opens valve 10-20% in one sec and this is not good.

What is wrong with LUA here?

--[[

%% autostart

%% properties

163 value

203 value

23 value

%% globals

targetTemp1

--]]

local extTemp=tonumber(fibaro:getValue(23, "value"))

local outTemp=tonumber(fibaro:getValue(163, "value"))

local ventiil=tonumber(fibaro:getValue(203, "value"))

local target2=tonumber(fibaro:getGlobalValue("targetTemp2"))

local hysteresis=tonumber(fibaro:getGlobalValue("hysterees"))

--local outtemp=tonumber(fibaro:getValue(36, "value"))

fibaro:debug(tonumber(target2))

fibaro:debug(tonumber(outTemp))

fibaro:call(202, "setProperty", "ui.lblTempout.value", outTemp)

fibaro:call(202, "setProperty", "ui.lblTarget.value", target2)

fibaro:call(202, "setProperty", "ui.lblTempExt.value", extTemp)

fibaro:call(202, "setProperty", "ui.lblVentiil.value", ventiil)

fibaro:call(202, "setProperty", "ui.lblHyst.value", hysteresis)

if target2 - outTemp > hysteresis then

--peab kütma

if ventiil<=99 then

fibaro:debug("kütame,erinevus: "..target2 - outTemp)

fibaro:debug("must HEAT")

fibaro:call(203, "setValue", ventiil+1)

fibaro:sleep(1000*10)

else

--fibaro:call(203, "open")

fibaro:debug("ventiil avatud :"..ventiil)

end

else

if ventiil>=1 then

fibaro:debug("jahutame,erinevus: "..target2 - outTemp)

fibaro:debug("must COOL")

fibaro:call(203, "setValue", ventiil-1)

fibaro:sleep(1000*10)

else

--fibaro:call(203, "close")

fibaro:debug("ventiil suletud: "..ventiil)

end

--fibaro:sleep(1000)

end

Lauri

[Guest GG]

%% properties

203 value

I think the problem is that yopu have 203 value under %%properties.

This makes this scene trigger each time the value of that device changes.

In your case, when you

fibaro:call(203, "setValue", ventiil+1)

the scene will be triggered again.

Remove 203 value from %%properties and it sould work better.

[robmac 173]

Everything is OK, but opening and closing the valve is not 1% and 10sec interval instead it opens valve 10-20% in one sec and this is not good.

Hi,

put

Please login or register to see this code.

at the top or it will run many times and you will therefore change the settings in very quick time. The scenes can run multiple instances at a time. That is good in some instances but be careful not to allow this when you do not want it. You do not for this.

Nice bit of code though.

You could also consider using a version of

Please login or register to see this link.

dawn simulator but would need some changes.

Please login or register to see this code.

[Lauri 6]

Hello,

Thanks alot guys, I did both and now it seems to be working really well

Please login or register to see this image.

/emoticons/default_icon_cool.gif" alt="8-)" />

I use this to control 3way walve whichs is responsible for keeping underfloor heating water temperature according outside temp.

Thanks again!

Lauri