Virtual thermostat issue

[Iztok88 0]

Hi guys, 

 

I am trying to create a virtual thermostat in HC2 using a fibaro flood sensor for temperature sensor and an everspring wallplug for on/off switching. In practice different devices will be used this is just to see if it works. In virtual devices I create a slider(for setting the temperature) and a label. Once I input all the codes I get an error message saying: "line4: attempt to compare string with nil"

 

These are the codes:

 

For the slider:

function map_range( a1, a2, b1, b2, s )
return math.floor(b1 + (s-a1)*(b2-b1)/(a2-a1))
end
111 = map_range(0, 100, 10, 35, _sliderValue_ )
fibaro:setGlobal("111", 111)
fibaro:call(fibaro:getSelfId(), "setProperty", "ui.label1.value", 111)

 

For the main loop:

roomTemp = fibaro:getValue(14, "value");
roomSetTemp = fibaro:getGlobal("111");
if (roomSetTemp > roomTemp) then
  fibaro:debug("on")
  fibaro:call(16, "turnOn")
elseif
  (roomSetTemp <= roomTemp) then
  fibaro:debug("off")
  fibaro:call(16, "turnOff")
end

 

111 - room number

14 - flood temp sensor id

16 - wallplug id

 

 

I have played around with this and from what I can gather the problem is somewhere in the roomsettemp part of the code. I'd apreciate the help if anybody has any idea whats wrong. I got this process of creating a virtual thermostat somewhere online. 

 

 

[Sankotronic 2,370]

Hi @Iztok88 and welcome to Fibaro forum!

 

You cannot use number as local variable so replace 111 with _111 and then it might work.

 

[Iztok88 0]

Hi @Sankotronic 

 

Thanks for the response. Yeah i've tried to change that to _111 and a few other things as well (t_111 was in the original example), unfortunatley it doesn't really change anything.

 

Given the error(compare string with nil) i'm now trying the tonumber() command with the roomTemp and the roomSetTemp but it just reports a different error(compare number with nil)

 

Anyway, thanks for the help.  

[Sankotronic 2,370]

Hi @Iztok88,

 

Here, put this code for slider:

Please login or register to see this code.

and then put this code to main loop:

Please login or register to see this code.

Since you can't use 111 as a name for global variable (I tested and system does not allow that!!!) you can add "TempSet" global variable. 

 

Then you had typo in "ui.Label1.value" since system gives that name with big L in Label and you put small l. If you make such typo system is not giving you any errors just value is not displayed on label as expected.

 

When you are using commands for devices like fibaro:call(16, "turnOn") and putting them in some loop, then it is necessary and required practice that you check if device is turned On and send command only if it is not. Otherwise if you make several loops like the one above you will quickly end up with system not responding and with delays because z-wave network will be overwhelmed with so many commands send!

 

I tested above code on my HC2 and it is working as expected, except I was turning light on/off, and I used temperature sensor from motion sensor.

Edited April 27, 2017 by Sankotronic

[Iztok88 0]

Thanks for the help, but I am getting the same result.

Line4: attempt to compare string with nil.

 

I copy pasted your code and then tried some stuff. Tried using different devices and changing some of the variables but just can't get it to work. 

 

 

[Sankotronic 2,370]

2 hours ago, Iztok88 said:

Thanks for the help, but I am getting the same result.

Line4: attempt to compare string with nil.

 

I copy pasted your code and then tried some stuff. Tried using different devices and changing some of the variables but just can't get it to work. 

 

 

 

Did you add global variable "TempSet" to variable panel?