Please help me with LUA to set lights to previous level after a scene turns a light off

[sarf77 11]

Hi all, 

 

I am trying to incorporate a previous state into a lua lighting scene. 

 

For example, if I trigger the scene, it takes reference of the current state of relay ID 81 and also 'value' of Dimmers ID 114 and 109 . 

Scene will then call Relay54 'turnOn' and Dimmer 114 setValue 10 and 109 to  'setvalue', 100 

 

I then wish to return those two loads to their previous state or level after 15 mins. 

 

 

Could somebody please help with this code. Dimmers are behaving properly (ID 114 and 109) but I'm having troubles with value, set value etc for the relay. 

 

At the end of the scene, the relay 54 stays turned on even if it was off before. 

 

 

 

%% properties

%% events
%% globals

--]]

local dining
local garage
local backyard

dining = tonumber (fibaro:getValue (114, 'value'));
fibaro:setGlobal  ('dining', dining);
fibaro:debug  ("dining level set") 
fibaro:debug (dining) 

backyard = tonumber (fibaro:getValue (109, 'value'));
fibaro:setGlobal  ('backyard', backyard);
fibaro:debug  ("backyard level set")
fibaro:debug (backyard) 
 

garage = tonumber ( fibaro:getValue(54, "value"));
fibaro:setGlobal  ('garage', garage);
fibaro:debug  ("garage level set")
fibaro:debug (garage) 

fibaro:call(114, 'setValue', '10');
fibaro:call(109, 'setValue', '100');
fibaro:call(54, 'turnOn');
fibaro:debug ("all lights on from scene activation")
fibaro:debug ("I will now wait 20 seconds")

fibaro:sleep (20000);
fibaro:debug ("wait over set all lights back to previous levels") 

fibaro:call(114, 'setValue', dining );
fibaro:call(109, 'setValue', backyard );
fibaro:call(54, 'setValue', garage );
fibaro:debug ("all lights back to previous levels")

 

 

 

Edited May 25, 2019 by sarf77

[sarf77 11]

 I have also tried this variant with no luck. 

 

Dimmers working spot on but relay wont play ball. 

 

--[[
%% properties

%% events
%% globals

--]]

local dining
local garage
local backyard

dining = tonumber (fibaro:getValue (114, 'value'));
fibaro:setGlobal  ('dining', dining);
fibaro:debug  ("dining level set"); 
fibaro:debug (dining); 

backyard = tonumber (fibaro:getValue (109, 'value'));
fibaro:setGlobal  ('backyard', backyard);
fibaro:debug  ("backyard level set");
fibaro:debug (backyard); 
 

garage = tonumber (fibaro:getValue(54, 'value'));
fibaro:setGlobal  ('garage', garage);
fibaro:debug  ("garage level set");
fibaro:debug (garage); 

fibaro:call(114, 'setValue', '10');
fibaro:call(109, 'setValue', '100');
fibaro:call(54, 'turnOn');
fibaro:debug ("all lights on from scene activation");
fibaro:debug ("I will now wait 20 seconds");

fibaro:sleep (20000);
fibaro:debug ("wait over set all lights back to previous levels"); 

fibaro:call(114, 'setValue',dining );
fibaro:debug ('dining set back')
fibaro:call(109, 'setValue',backyard );
fibaro:debug ('backyard set back')
if ('garage' == '0') then
  fibaro:call (54, 'turnOff')
  end

fibaro:debug ('garage set back')
  

fibaro:debug ("all lights back to previous levels");

 

 

[jgab 2,642]

2 hours ago, sarf77 said:

Dimmers working spot on but relay wont play ball. 

Please login or register to see this code.

 

This test the string 'garage' against the string '0'.  You want to test the variable garage against the number 0

Please login or register to see this code.

 

Edited May 25, 2019 by jgab

[MARCUSP.I.L 16]

Maybe you can try this?

 

 

--[[
%% properties
%% events
%% globals
114 value
109 value
54 value
--]]

local dining = fibaro:getValue(114, "value")
local backyard = fibaro:getValue(109, "value")
local garage = fibaro:getValue(54, "value")

if 
  (tonumber(fibaro:getValue(81, "value")) == tonumber("1"))--- your ID 81 turned on 
  then
 fibaro:setGlobal('backyard', "backyard");
 fibaro:setGlobal('dining', "dining");
 fibaro:setGlobal('garage', "garage");
 fibaro:debug(" Globals backyard dining garage set")
fibaro:call(114, 'setValue', '10');
fibaro:call(109, 'setValue', '10');
fibaro:call(54, 'turnOn');
fibaro:debug ("all lights on from scene activation")
fibaro:debug ("I will now wait 20 seconds")
fibaro:sleep (20000);
fibaro:debug ("wait over set all lights back to previous levels") 
fibaro:call(114, 'setValue', dining );
fibaro:call(109, 'setValue', backyard );
fibaro:call(54, 'turnOff');
fibaro:debug ("all lights back to previous levels")
end

---more code to do if ID 81 IS 0 ?????

[sarf77 11]

42 minutes ago, jgab said:

This test the string 'garage' against the string '0'.  You want to test the variable garage against the number 0

Please login or register to see this code.

 

jgab, 

 

Thanks so much for your help. I'm VERY new to LUA and normally just grab code from other sources to achieve my result. This one I did from scratch and this last part had me stumped for hours. You saved me. Thank you  

Works a treat now. 

 

The script will now be modified to suit a larger scale where I have a set of gates triggering a USB that set a welcome scene going. It turns on around 12 different mixed loads and some may already be in use when scene starts. When the scene times out it will set everything back as it was. 

 

im starting to now think I don't need the global variables at all? I'll go back through and rethink that.  

 

 

Thanks again. 

[jgab 2,642]

18 hours ago, sarf77 said:

jgab, 

 

Thanks so much for your help. I'm VERY new to LUA and normally just grab code from other sources to achieve my result. This one I did from scratch and this last part had me stumped for hours. You saved me. Thank you  

Works a treat now. 

 

The script will now be modified to suit a larger scale where I have a set of gates triggering a USB that set a welcome scene going. It turns on around 12 different mixed loads and some may already be in use when scene starts. When the scene times out it will set everything back as it was. 

 

im starting to now think I don't need the global variables at all? I'll go back through and rethink that.  

 

 

Thanks again. 

 

You typically only need to store something in a global if you need to remember something between two different invocations of a scene (or sometimes as extra security if you have a long running scene that may crash, and need to remember what it was doing when restarting).

If you trigger, set some lights, sleep, restore some lights - then you shouldn't need to store the state in a variable.

[sarf77 11]

On 5/25/2019 at 10:05 PM, MARCUSP.I.L said:

Maybe you can try this?

 

 

--[[
%% properties
%% events
%% globals
114 value
109 value
54 value
--]]

local dining = fibaro:getValue(114, "value")
local backyard = fibaro:getValue(109, "value")
local garage = fibaro:getValue(54, "value")

if 
  (tonumber(fibaro:getValue(81, "value")) == tonumber("1"))--- your ID 81 turned on 
  then
 fibaro:setGlobal('backyard', "backyard");
 fibaro:setGlobal('dining', "dining");
 fibaro:setGlobal('garage', "garage");
 fibaro:debug(" Globals backyard dining garage set")
fibaro:call(114, 'setValue', '10');
fibaro:call(109, 'setValue', '10');
fibaro:call(54, 'turnOn');
fibaro:debug ("all lights on from scene activation")
fibaro:debug ("I will now wait 20 seconds")
fibaro:sleep (20000);
fibaro:debug ("wait over set all lights back to previous levels") 
fibaro:call(114, 'setValue', dining );
fibaro:call(109, 'setValue', backyard );
fibaro:call(54, 'turnOff');
fibaro:debug ("all lights back to previous levels")
end

---more code to do if ID 81 IS 0 ?????

Mate THANK you.

 

I see the simplicity in that.

 

I don't understand the difference however between '  '   and "  " . Would you mind explaining?

 

 

Also, why are we declaring the global variables up top? what does that mean?

 

 

[MARCUSP.I.L 16]

The    '  ' and "  " as well as globals use is best explained in official fibaro lua api manual;

or

by looking on forum.

Please login or register to see this link.

I have a tendency to copy from blocks and  " "  is therefore used in the scene for values and globals.

Also you can drop the  ==tonumber("1") and replace with == 'value' > 0. for example.

 

 

Hei, have a look at below site for a little more info about lua and fibaro;

Please login or register to see this link.

 

Your above scene can be written in many ways, but agreeing with @jgab no need to store light state in globals, although i like the handy idea of storing the previous value.

Search for @jgab, as well as many others who ar far more experienced than me, for ideas.

 

I have a block test scene that i use to look at lua,

(create a scene in block and temporarily change to LUA to have a look at code.)

Pay attention to order of  headers.

Good luck

[sarf77 11]

15 hours ago, MARCUSP.I.L said:

The    '  ' and "  " as well as globals use is best explained in official fibaro lua api manual;

or

by looking on forum.

Please login or register to see this link.

I have a tendency to copy from blocks and  " "  is therefore used in the scene for values and globals.

Also you can drop the  ==tonumber("1") and replace with == 'value' > 0. for example.

 

 

Hei, have a look at below site for a little more info about lua and fibaro;

Please login or register to see this link.

 

Your above scene can be written in many ways, but agreeing with @jgab no need to store light state in globals, although i like the handy idea of storing the previous value.

Search for @jgab, as well as many others who ar far more experienced than me, for ideas.

 

I have a block test scene that i use to look at lua,

(create a scene in block and temporarily change to LUA to have a look at code.)

Pay attention to order of  headers.

Good luck

Thanks very much Marcus for the above resources and advice.

As you can see I'm sure, I'm doing what i can to get stuff working correctly. After that i will learn to consolidate and streamline my code.

As for the previous values, I feel that any lighting scene should return to its previous state once finished and I'm trying to make this a standard in our business.