triggering scenes

[jorge rintaro 8]

Please login or register to see this code.

 

--[[
%% autostart
%% properties
965 value
%% weather
%% events
%% globals
--]]

local startSource = fibaro:getSourceTrigger();

if
(( tonumber(fibaro:getValue(965, "value")) > 0 -- sensor 1 violado (trigger)
and  tonumber(fibaro:getValue(966, "value")) > 0) -- sensor 2
or startSource["type"] == "other")
  
  then
  fibaro:debug (" Turn Off  buzzer")
  fibaro:call(970, "turnOn")
  fibaro:sleep (6000)
  fibaro:call(970, "turnOff")
  else
  fibaro:debug ("Nothing do...")
  fibaro:abort()
  end

[Tim__ 126]

If I understand correctly, your sensor device sends two notifciations and you only want to action on the first one. How long is the time between "being violated" and "being sure"?  If it is less than 6000ms, you could solve your problem by adding an extra condition to your "if" statement, that checks if the buzzer is not already on.

ie something like the below, syntax will depend on what your device actually is.

and tonumber(fibaro:getValue(970, "value")) == 0)

 

If it is longer than 6000ms, then you might need to set a global variable when "violated", and reset it "when sure", because actions are happening outside when each instance of your script is running.  Setting the variable looks like this, put this *after* your first if statement:

if (( tonumber(fibaro:getValue(965, "value")) > 0

then

AlreadyViolated == 1;

end

 

Then add another condition to your main "if", eg

and AlreadyViolated == 1

 

Also, do you need some semicolons (;) at the end of lines?

 

[jorge rintaro 8]

Please login or register to see this code.

[jgab 2,642]

4 hours ago, jorge rintaro said:

Please login or register to see this code.

 

Semicolons are (99.9999%) optional in Lua. It's debated if they add to readability. Normally you break statements up by lines instead of stringing them up on a single line anyway.

[Tim__ 126]

1 hour ago, jgab said:

Semicolons are (99.9999%) optional in Lua

 

And now I know the answer, thanks @jgab  

[jgab 2,642]

5 minutes ago, Tim__ said:

 

And now I know the answer, thanks @jgab  

 

Only if you happen to write code like this does it matter

Please login or register to see this code.

...and it's still not ambiguous - the Lua syntax is clear on preferring function call chaining

Edited August 14, 2020 by jgab

[jorge rintaro 8]

jgab@, 

thanks for today's class....

Tim_@

thanks!