Simple scene and number of running instances?

[sega66 2]

I have two simple scenes that should turn on the boiler pumps (528 and 529) if at least one of the valves (941,942 and 943) is open. And another scene that turns off the pumps when all the valves are closed. If I limit these scenes to a single instance-they don't work, why? And is it possible to combine these two scenes?

--[[
%% autostart
%% properties
941 value
942 value
943 value
%% weather
%% events
%% globals
--]]

if fibaro:countScenes()>3 then os.exit()end

local startSource = fibaro:getSourceTrigger();
if (
 ( tonumber(fibaro:getValue(941, "value")) > 0 )
or
 ( tonumber(fibaro:getValue(942, "value")) > 0 )
or
 ( tonumber(fibaro:getValue(943, "value")) > 0 )
or
startSource["type"] == "other"
)
then
  fibaro:debug("ON  .....");
    setTimeout(function()
        fibaro:call(528, "turnOn");
    end, 5000)
    setTimeout(function()
        fibaro:call(529, "turnOn");
    end, 10000)
end

----------------------------------------------------------------------------

--[[
%% autostart
%% properties
941 value
942 value
943 value
%% weather
%% events
%% globals
--]]

if fibaro:countScenes()>3 then os.exit()end

local startSource = fibaro:getSourceTrigger();
if (
 ( tonumber(fibaro:getValue(941, "value")) == 0 )
and
 ( tonumber(fibaro:getValue(942, "value")) == 0 )
and
 ( tonumber(fibaro:getValue(943, "value")) == 0 )
or
startSource["type"] == "other"
)
then
  fibaro:killScenes(198);
   fibaro:debug("OFF  .....");
    setTimeout(function()
        fibaro:call(529, "turnOff");
    end, 5000)
    setTimeout(function()
        fibaro:call(528, "turnOff");
    end, 10000)
end
 

[Alex de Bruin 21]

remove the unnecessary %% autostart and use the following example code

 

local action = "turnOff"
if tonumber(fibaro:getValue(941, "value")) +
   tonumber(fibaro:getValue(942, "value")) +
   tonumber(fibaro:getValue(943, "value")) > 0 then action = "turnOn"

end

fibaro:call(528, action)
fibaro:call(529, action)

[sega66 2]

This beautiful code works great! Thanks

Please login or register to see this link.

!

How best to organize the delay between fibaro:call(528, action)  and fibaro:call(529, action)

fibaro:sleep(5000);  or  setTimeout(function() ?

[Alex de Bruin 21]

Whatever you like best. Mostly I myself use the fibaro:sleep function.

 

Example of somewhat more sophisticated coding:

 

Please login or register to see this code.

 

Edited March 10, 2021 by Alex de Bruin

[sega66 2]

Thanks 

Please login or register to see this link.

!

I tried more complex code, but it doesn't work. The pumps are turned on without delay, and the scene is started for as long as it costs in this line 

Please login or register to see this code.

Here is my full code

--[[
%% autostart
%% properties
941 value
942 value
943 value
532 value
--]]

 

function getval(valve) return tonumber(fibaro:getValue(valve, "value")) end

function switch(pump,onoff,wait)
   fibaro:debug(onoff .. " .....")
   fibaro:call(pump, "turn" .. onoff)
   fibaro:sleep(wait * 1000)
end

action = "Off"
if getval(941) + getval(942) + getval(943) > 0 then action = "On" end

switch(528,action,60)
switch(529,action,120)

[Alex de Bruin 21]

move the call command behind the sleep.
 

Please login or register to see this code.

 

Edited March 15, 2021 by Alex de Bruin