simple qa which allows me to add 1 to a stored variable

[Jay Ess 6]

Hi,

I am trying to make a simple qa with two buttons and one label, which shows me the number stored in a variable and if i press one botun it will add one to the variable and the other button is take off 1.

I have

function QuickApp:UpdateNightLevelVarable(NewLightLevel)

    fibaro.setGlobalVariable("upHallwayNightLevel", NewLightLevel)

    --NightLevelVariable = fibaro.getGlobalVariable("upHallwayNightLevel")

    --self:updateView("lblNewNightLevel","text",NightLevelVariable)

end

 

function QuickApp:PlusOne()

    NewLightLevel = NewLightLevel + 1

    print (NewLightLevel)

    self:UpdateNightLevelVarable(NewLightLevel)

end

 

function QuickApp:MinusOne()

    NewLightLevel = NewLightLevel - 1

    print (NewLightLevel)

    self:UpdateNightLevelVarable(NewLightLevel)

end

When I press the plus1 or minus1 i get this error:

[16.03.2021] [17:06:45] [ERROR] [QUICKAPP275]: QuickApp crashed

[16.03.2021] [17:06:45] [ERROR] [QUICKAPP275]: Unknown error occurred: handleJsonRpc

 

i assume it is due to the param i have in the function UpdateNightLevelVarable, can you tell me what is the proper way of sending the number when i call the function please?

[Sankotronic 2,370]

Hi @Jay Ess,

 

I have write and tested this code for you:

 

Please login or register to see this code.

 

Above code will add global variable to system automatically if is missing. Your code didn't work for several reasons:

1. function fibaro.getGlobalVariable() is always returning two data, global value (v in code) and time when was last changed (t in code).
2. function fibaro.getGlobalVariable() is always returning global variable value as string, so it needs to be converted to number for doing calculations. Normally LUA supports comparison of numerical values that are stored as string type eg. comparing time "10:00" > "09:00" will give true answer, but for calculations the best is to convert numerical values to numeric format with tonumber("11") == 11
3. For some reason function updateView does not like arguments in numeric format except if they are concatenated to the string:
   • self.updateView("label","Night level: "..v) - this format works
   • self.updateView("label",v) - this format doesn't work if v is formatted as number
   • self.updateView("label",tostring(v)) - this format work since v is formatted to string

Hope this shed some light on why sometimes code fails.

I have also added checking of the MIN and MAX values since usually dimmer values goes from 0 - turned off to 99 - max brightness. (yes 99 is correct and some devices doesn't work if 100 is sent as brightness value.

 

Enjoy coding

 

[Jay Ess 6]

@Sankotronic  thank you ever so much for your help, amazing help and helps me to get a better understanding of the lua code at the same time.

 

One more question please, if the value is at 99 how can i hide the plusone button?

[Sankotronic 2,370]

On 3/21/2021 at 11:06 AM, Jay Ess said:

One more question please, if the value is at 99 how can i hide the plusone button?

 

Here is solution, not with hiding buttons, but with changing label:

Please login or register to see this code.

 

You can of course replace MIN and MAX labels with anything you like more. I have also added that QA shows proper value of the global variable when QA is restarted

 

 

[Jay Ess 6]

10 hours ago, Sankotronic said:

 

Here is solution, not with hiding buttons, but with changing label:

Please login or register to see this code.

 

You can of course replace MIN and MAX labels with anything you like more. I have also added that QA shows proper value of the global variable when QA is restarted

 

 

thank you for your insight and help