Help combining 2 LUA scripts onto one!

[JamieSonegoAus 6]

Hi,

 

Still new to LUA.. I have created two scenes to simple notify me when a door is opened and closed. Surely there is a cleaner way to have this running in a single scene?

 

Scene 1:

 

 

local startSource = fibaro:getSourceTrigger();
if (
 ( tonumber(fibaro:getValue(377, "value")) > 0 )
or
startSource["type"] == "other"
)
then
    fibaro:call(2, "sendDefinedEmailNotification", "342");
    api.post('/mobile/push', {["mobileDevices"]={373}, ["message"]=[[The gun safe door is OPEN]], ["title"]='GunSafe_Open', ["category"]='RUN_CANCEL', ["data"]={["sceneId"]=9}});
end

 

 

Scene 2:

 

 

local startSource = fibaro:getSourceTrigger();
if (
 ( tonumber(fibaro:getValue(377, "value")) == 0 )
or
startSource["type"] == "other"
)
then
    fibaro:call(2, "sendDefinedEmailNotification", "343");
    fibaro:call(373, "sendDefinedPushNotification", "343");
end

 

 

 

 

 

 

 

Thank you

[SmartHomeEddy 1,005]

10 minutes ago, JamieSonegoAus said:

The gun safe door is OPEN

??? only in Australia (almost)

[FBERRIERE 0]

Hi, i believe this should work

 

Please login or register to see this code.

 

[Tim__ 126]

12 hours ago, SmartHomeEddy said:

??? only in Australia (almost)

On topic, but off topic... just to ensure a correct view of us Aussies:

 

3% of Australians own a gun (these must be kept in a gun safe)

30% of Americans own a gun (these seem to be kept in ones back pocket or the car glovebox, ready for immediate use)

 

I know where I'd rather live!! ?

[jgab 2,642]

5 hours ago, Tim__ said:

On topic, but off topic... just to ensure a correct view of us Aussies:

 

3% of Australians own a gun (these must be kept in a gun safe)

30% of Americans own a gun (these seem to be kept in ones back pocket or the car glovebox, ready for immediate use)

 

I know where I'd rather live!! ?

Yes, just that riffle holders for your bed is a thing in the US tells a lot  

Please login or register to see this link.

 

[morpheus75 77]

hi

here is the simple solution:

 

--[[

%% properties

377 value

%% events

%% globals

--]]

 

 

local door = fibaro:getValue(377, "value")

 

if (door == '1') then

fibaro:call(2,'sendPush','The Gun Safe Door is Open')

fibaro:call(373,'sendPush','The Gun Safe Door is Open')

 

end

 

if (door == '0') then

fibaro:call(2,'sendPush','The Gun Safe Dor is Closed')

fibaro:call(373,'sendPush','The Gun Safe Door is Closed')

 

end