function to switch on group of lights

[Jay Ess 5]

Hi, I am trying to store a function, in a qa where i store other functions too, which will switch on a group of lights using the following:

function QuickApp:TurnOnLights(GroupName,SetLightOnLevel)

    for k,i in ipairs(GroupName) do

        if fibaro.getType(i) == "com.fibaro.FGD212" then

            if fibaro.getValue(i, "value") ~= SetLightOnLevel then

                fibaro.call(i, "setValue",SetLightOnLevel)

                fibaro.sleep(1000)

            end

        else

            if fibaro.getValue(i, "state") == false then

                fibaro.call(i, "turnOn")

            end

        end

    end

end

 

I then was hoping to call it from a scene as follows:

fibaro.call(FunctionDeviceId, "TurnOnLights","GroupLight",50)

 

FunctionDeviceId refers to the qa device id

 

how do i pass the device id's to the function to be able to control the lights needed?

 

Edited May 5, 2021 by Jay Ess

[Tim__ 112]

Someone else may wish to correct me, but I understand that the only way to pass state information or variables between scripts is to use Global Variables. 

[jgab 1,957]

On 5/5/2021 at 5:39 PM, Jay Ess said:

Hi, I am trying to store a function, in a qa where i store other functions too, which will switch on a group of lights using the following:

function QuickApp:TurnOnLights(GroupName,SetLightOnLevel)

    for k,i in ipairs(GroupName) do

        if fibaro.getType(i) == "com.fibaro.FGD212" then

            if fibaro.getValue(i, "value") ~= SetLightOnLevel then

                fibaro.call(i, "setValue",SetLightOnLevel)

                fibaro.sleep(1000)

            end

        else

            if fibaro.getValue(i, "state") == false then

                fibaro.call(i, "turnOn")

            end

        end

    end

end

 

I then was hoping to call it from a scene as follows:

fibaro.call(FunctionDeviceId, "TurnOnLights","GroupLight",50)

 

FunctionDeviceId refers to the qa device id

 

how do i pass the device id's to the function to be able to control the lights needed?

 

You call 

Please login or register to see this code.

with a string "GroupLight" - shouldn't it be a table?

 

In any case,  I would say that the scene's fibaro.call is a bit buggy.

To call your QA function from à Scene with a table you need to json.encode it

GroupLight = {55,66,77}

Please login or register to see this code.

then it will arrive at the QA function as a table of deviceIds...

If you don't encode it it will arrive as a 'tostring(GroupLight)' which is not what we want.

Note if you call the QA from another QA you should not json encode the table - tables are passed as tables between QAs

Edited May 9, 2021 by jgab