LUA | if id ne xx or xx then do

[Symbiot78 2]

Hi

 

I'm trying to excude 2 id's from a bit of lua code.

could someone take a look at this and tell me if it's in the right direction?

 

local lightsOn = {}

local lightsf = api.get("/devices?interface=light")

for _, light in ipairs(lightsf) do

    if (light.visible == true and light.properties.state == true) then

--153,158

    if (light.id ~= 153 or light.id ~= 158 ) then -- this?

 

        table.insert(lightsOn, light.id)

    end

end

 

if (next(lightsOn) ~= nil) then

    fibaro.call(lightsOn, "turnOff")

end

[Symbiot78 2]

so 2 things worked.. 

 

1. using the right ID

2. using AND as I knew I should.. but didn't

 

this works and if you are curious as to what I want to do.. it's for the alarm. So when alarm is armed.. turn off all lights.. but not garden/outdoor lights. This is assuming it's supposed to be turned on of course.. I may add some time barrier to this.

 

local lightsOn = {}

local lightsf = api.get("/devices?interface=light")

for _, light in ipairs(lightsf) do

    if (light.visible == true and light.properties.state == true) then

--153,158

    if (light.id ~= 154 and light.id ~= 159 ) then -- this?

 

        table.insert(lightsOn, light.id)

        end

    end

end

 

if (next(lightsOn) ~= nil) then

    fibaro.call(lightsOn, "turnOff")

end

[jgab 2,642]

Some Lua coding tips.

You can combine many selectors in /devices?...

t[#t+1]=x is twice as fast as table.insert(t,x)

Testing for exclusion for 2 devices is ok with 'and' - testing for more use a map

#table gets the length for an indexed array. next() is the idiom for testing key-value tables emptiness or not. #t is also about twice as fast as next(t)

 

Please login or register to see this code.

You could also look at fibaro.callGroupAction or fibaro.getDevicesID