Why does this line in my VD not work?

[Desmo 5]

This line here...

Please login or register to see this code.

gives the error "line getGlobal ("Nursery_S..."]:10""

 

Yet if I debug the values for those two lines I get correct figures

fibaro:debug(volume) = 15
fibaro:debug(jsonTable.volume) = 30

 

It's just a button to reduce the volume on my Sonos from the current volume (jsonTable.volume) until it reaches a preset volume (volume).

It's a simple "greater than" comparison but I just get this error all the time.

[T.Konopka 8]

The topic has been moved from "

Please login or register to see this link.

" to "

Please login or register to see this link.

".

 

Temat został przeniesiony z "

Please login or register to see this link.

" do "

Please login or register to see this link.

".

[Sankotronic 2,370]

Hi @Desmo,

 

That error line that you copy/pasted, is it complete because it seem like is missing part. Anyway it doesn't seems to be related to that line of code with volume check. Sometimes debugger gives wrong code line for shown error so check the rest of the code or at least try to copy/paste complete error line and even at least part of code that it refers to.

[Desmo 5]

Yep, that's the complete line of code. Like you say, it doesn't really make any sense so I'll check the rest of the code.

This is the entire code below. It controls my Sonos speaker and slowly fades the volume to the set amount, pauses playback and then returns volume to a preset state.

It seems to be the "Fade Volume" section that isn't working as the volume keeps going down to zero rather than stopping at the required volume

 

IP Address and Port have only been removed for security, they're all fine in the actual script.

 

@AutoFrank...I know you're very familiar with the Sonos setup....any ideas what might be wrong here? I'm sure all the Sonos stuff is working fine as the correct volume is being reported in the debug lines.

 

Please login or register to see this code.

 

Edited March 7, 2017 by Desmo

[Sankotronic 2,370]

Just try first with changing first line of code to:

Please login or register to see this code.

because function fibaro:getGlobal is always returning string value (even it contains number) while table can contain number value so it is possible that you are comparing string with numeric value.

[AutoFrank 372]

6 minutes ago, Desmo said:

Yep, that's the complete line of code. Like you say, it doesn't really make any sense so I'll check the rest of the code.

This is the entire code below. It controls my Sonos speaker and slowly fades the volume to the set amount, pauses playback and then returns volume to a preset state.

It seems to be the "Fade Volume" section that isn't working as the volume keeps going down to zero rather than stopping at the required volume

 

IP Address and Port have only been removed for security, they're all fine in the actual script.

 

@AutoFrank...I know you're very familiar with the Sonos setup....any ideas what might be wrong here? I'm sure all the Sonos stuff is working fine as the correct volume is being reported in the debug lines.

 

Please login or register to see this code.

 

 

 

Hi @Desmo

 

The code has a slight error, you're not updating the reference volume (current volume of player) to check against and as a result jsonTable.volume is always greater than volume and it iterates down to zero and actually continues to loop

you'll need to read back the new (reduced) volume and compare that against your target volume

I can't fix your code sample as I don't know all the variables in play but the following is working example that should show you how such a loop should work

 

-f

Please login or register to see this code.

drop it into ZeroBraine or a blank scene and you'll see the results

 

Please login or register to see this code.

 

[Desmo 5]

2 hours ago, Sankotronic said:

Just try first with changing first line of code to:

Please login or register to see this code.

because function fibaro:getGlobal is always returning string value (even it contains number) while table can contain number value so it is possible that you are comparing string with numeric value.

I think I had tried that before but did it again and that first line then showed the same error....

[ERROR] 13:33:03: line getGlobal (..."]:1

[Desmo 5]

2 hours ago, AutoFrank said:

The code has a slight error, you're not updating the reference volume (current volume of player) to check against and as a result jsonTable.volume is always greater than volume and it iterates down to zero and actually continues to loop

you'll need to read back the new (reduced) volume and compare that against your target volume

 

I have called the new reduced volume back in to the loop, lines 6 & 7...

Please login or register to see this code.

What I have noticed (and changed in the code above) is that if I use a figure instead of calling the global variable the code works perfectly.

It's just calling that variable that's causing a problem. I might try deleting the variable and starting again....could it be corrupt in any way?

[AutoFrank 372]

10 minutes ago, Desmo said:

 

I have called the new reduced volume back in to the loop, lines 6 & 7...

Please login or register to see this code.

What I have noticed (and changed in the code above) is that if I use a figure instead of calling the global variable the code works perfectly.

It's just calling that variable that's causing a problem. I might try deleting the variable and starting again....could it be corrupt in any way?

 

Hi @Desmo

It sounds like a data type compare issue left

 

@Sankotronic solution should work

Please login or register to see this code.

Could you drop this in and share whats in the debug window ?

[Desmo 5]

Same thing again... 

[ERROR] 14:44:06: line getGlobal ("Nursery_S..."]:11

 

I even created a new global variable but have the same results.

 

I could manually put the value in to the VD but I wanted it to be easily variable using a slider....this is just plain odd.

 

[AutoFrank 372]

14 minutes ago, Desmo said:

Same thing again... 

[ERROR] 14:44:06: line getGlobal ("Nursery_S..."]:11

 

I even created a new global variable but have the same results.

 

I could manually put the value in to the VD but I wanted it to be easily variable using a slider....this is just plain odd.

 

 

@Desmo

Thats a very odd error

 

Could you screenshot the whole debug window ?

[Desmo 5]

I've added some text to the debug lines so they make sense...

 

 

Please login or register to see this attachment.

[Sankotronic 2,370]

Ok, I didn't pay attention what function you use to get value from global variable. it is still problem with number & string comparison, but if you want to convert value from global variable to number then you must use fibaro:getGlobalValue instead of fibaro:getGlobal because former one is returning two values, value of the global variable and also time of the last change.

 

So this is correct syntax:

Please login or register to see this code.

and the it will work.

 

[Desmo 5]

Thanks @Sankotronic, I will give that a go later on and report back.

[AutoFrank 372]

30 minutes ago, Desmo said:

Thanks @Sankotronic, I will give that a go later on and report back.

@Desmo 

I missed that .. sorry 

If you are still having issues let me know and I can try and replicate on my setup at home

 

 

 

[Desmo 5]

Thanks for chipping in @AutoFrank and @Sankotronic....that last fix has worked a treat 

[AutoFrank 372]

19 minutes ago, Desmo said:

Thanks for chipping in @AutoFrank and @Sankotronic....that last fix has worked a treat 

@Desmo

glad it all worked out 

Edited March 7, 2017 by AutoFrank

[Sankotronic 2,370]

Great!

 

Happy that it works!