lua help needed

[Sjakie 156]

Hi guys,

I am stucked can you please help me?

In below code the GV will stay on "Ochtendgloren"

Thanks in advanced for your help

 

 --[[
%% autostart
%% properties
%% globals
--]]
local sourceTrigger = fibaro:getSourceTrigger();
if (sourceTrigger["type"] == "autostart") then
 
  local debug = true;

  -- check script instance count in memory
  if (tonumber(fibaro:countScenes()) > 1) then
    if debug then fibaro:debug("Script already running."); end
    fibaro:abort();
  end

  if debug then fibaro:debug("HC2 start script at " .. os.date()); end

  while true do
    local ochtendgloren = os.date("%H:%M", os.time()+50*60)
    local gordijnopen      = os.date("%H:%M", os.time()+15*60)
    local sunrise         = fibaro:getValue(1, "sunriseHour")

    
    local sunset         = fibaro:getValue(1, "sunsetHour")
    local gordijndicht  =os.date("%H:%M", os.time()-50*60)
    local avondrood      = os.date("%H:%M", os.time()-50*60)

    local currentTime     = os.date("%H:%M");
    local TimeOfDay     = fibaro:getGlobal("TijdStip");

--Sunrise
    
    if ( ochtendgloren >= sunrise and currentTime < gordijnopen and TijdStip ~= "Ochtendgloren" )
    then
      fibaro:setGlobal("TijdStip", "Ochtendgloren");
      if debug then fibaro:debug("Ochtendgloren"); end
     
      
       if ( gordijnopen >= sunrise and currentTime < sunrise and TijdStip ~= "GordijnOpen" )
    then
      fibaro:setGlobal("TijdStip", "GordijnOpen");
      if debug then fibaro:debug("GordijnOpen"); end

         
        
        
        
--sunset  
 

        
    elseif ( gordijndicht >= sunset and currentTime > sunset and TijdStip ~= "GordijnDicht" )
   then
    fibaro:setGlobal("TijdStip", "GordijnDicht");
     if debug then fibaro:debug("GordijnDicht"); end
              
    
        
    elseif ( avondrood >= sunset and currentTime > sunset and TijdStip ~= "Avondrood" )
    then
      fibaro:setGlobal("TijdStip", "Avondrood");
      if debug then fibaro:debug("Avondrood"); end
      
     end
    fibaro:sleep(60*1000);
  end
end
   else
  fibaro:debug("Script can only be run via autostart")
  end

[Bodyart 231]

Hi @Sjakie,

in your script you are defining TimeOfDay representing value of global variable TijdStip, but you are not testing on TimeOfDay, but on TijdStip.

I hope this helps....

Edited April 7, 2019 by Bodyart

[Sjakie 156]

Bodyart@, Thanks for the tip.

I corrected it but it still gives me Script can only run "Autostart" while other scene shows in debug the present GV.

 

[Sankotronic 2,370]

Hi @Sjakie ,

 

try this code:

Please login or register to see this code.

 

[Sjakie 156]

Hi @Sankotronic, thank you very much!

It is almost working, it will stay on "Ochtendgloren"

I thought for you to better understand I will translate and I added one extra line to test if it is working.

Regretfully  it is doing something it is changing between Dawn and DayTime, please can you look into it?

Thanks in advance and sorry to bother you

 

--[[
%% autostart
%% properties
%% globals
--]]

if tonumber(fibaro:countScenes())>1 then os.exit() end

local sourceTrigger=fibaro:getSourceTrigger()
if (sourceTrigger["type"]=="autostart") then
  local debug=true
  -- check script instance count in memory
  if debug then fibaro:debug("HC2 start script at "..os.date()) end
  while true do
    local Sanco3         = fibaro:getGlobal("Sanco3")
    local currentTime   = os.date("%H:%M")
    local dawn          = os.date("%H:%M", os.time()+50*60)
    local curtainopen = os.date("%H:%M", os.time()+15*60)
    local sunrise       = fibaro:getValue(1, "sunriseHour")
    local daytime       = os.date("%H:%M", os.time()+1*60)
    local sunset        = fibaro:getValue(1, "sunsetHour")
    local curtainclose = os.date("%H:%M", os.time()-50*60)
    local eveningred     = os.date("%H:%M", os.time()-50*60)
    --Sunrise
    if (dawn >= sunrise and currentTime < curtainopen and Sanco3 ~= "Dawn" ) then
      fibaro:setGlobal("Sanco3", "Dawn")
      if debug then fibaro:debug("Dawn") end
   
    elseif ( curtainopen >= sunrise and currentTime < sunrise and Sanco3 ~= "CurtainOpen" ) then
      fibaro:setGlobal("Sanco3", "CurtainOpen")
      if debug then fibaro:debug("CurtainOpen") end

   elseif ( daytime >= sunrise and currentTime < sunset and Sanco3 ~= "DayTime" ) then
      fibaro:setGlobal("Sanco3", "DayTime")
      if debug then fibaro:debug("DayTime") end   
      
      
      
      --sunset  
    elseif ( curtainclose >= sunset and currentTime > sunset and Sanco3 ~= "CurtainClose" ) then
      fibaro:setGlobal("Sanco3", "CurtainClose");
      if debug then fibaro:debug("CurtainClose"); end
    elseif ( eveningred >= sunset and currentTime > sunset and Sanco3 ~= "EveningRed" ) then
      fibaro:setGlobal("Sanco3", "EveningRed");
      if debug then fibaro:debug("EveningRed"); end
    end
    fibaro:sleep(60*1000);
  end
else
  fibaro:debug("Script can only be run via autostart")
end

Please login or register to see this attachment.

[Bodyart 231]

Hi @Sjakie,

 

your script works perfectly on my HC2

 

Dit you define the global variable with filled in values?

[Sjakie 156]

Hi, see what you get as second line in debug.

[Bodyart 231]

I've added some debug lines:

Please login or register to see this image.

/monthly_2019_04/image.png.f4953bb21ce27737238342c85f3256e2.png" />

those values don't look right to me except sunrise & sunset

 

Edited April 8, 2019 by Bodyart

[Sjakie 156]

yep thats why he is changing GV what is not expected and I do not have a clue what is wrong.

what did you add?

[Bodyart 231]

This:

Please login or register to see this attachment.

[Sjakie 156]

the time behind the debug include the difference between the actions only the begin time is wrong?

[Bodyart 231]

I think your definition of ochtendgloren should depend in sunrise and avondrood on sunset, doesn't it?

[Sjakie 156]

yes it is

[Bodyart 231]

is it???

then why it shows such weird time?? see debug above 16:41 !

[Sjakie 156]

hi use this one its in English

 

 

--[[
%% autostart
%% properties
%% globals
--]]

if tonumber(fibaro:countScenes())>1 then os.exit() end

local sourceTrigger=fibaro:getSourceTrigger()
if (sourceTrigger["type"]=="autostart") then
  local debug=true
  -- check script instance count in memory
  if debug then fibaro:debug("HC2 start script at "..os.date()) end
  while true do
    local Sanco3         = fibaro:getGlobal("Sanco3")
    local currentTime   = os.date("%H:%M")
    local dawn          = os.date("%H:%M", os.time()+50*60)
    local curtainopen = os.date("%H:%M", os.time()+15*60)
    local sunrise       = fibaro:getValue(1, "sunriseHour")
    local daytime       = os.date("%H:%M", os.time()+1*60)
    local sunset        = fibaro:getValue(1, "sunsetHour")
    local curtainclose = os.date("%H:%M", os.time()-50*60)
    local eveningred     = os.date("%H:%M", os.time()-50*60)
    
fibaro:debug("sunrise: ".. sunrise)
  fibaro:debug("sunset: "..sunset)
    fibaro:debug("Sanco3: ".. Sanco3)
      fibaro:debug("dawn: "..dawn)
    fibaro:debug("curtainopen: ".. curtainopen)
  fibaro:debug("daytime: "..daytime)
    fibaro:debug("curtainclose: ".. curtainclose)
      fibaro:debug("eveningred: "..eveningred)
    
    --Sunrise
    if (dawn >= sunrise and currentTime < curtainopen and Sanco3 ~= "Dawn" ) then
      fibaro:setGlobal("Sanco3", "Dawn")
      if debug then fibaro:debug("Dawn") end
   
    elseif ( curtainopen >= sunrise and currentTime < sunrise and Sanco3 ~= "CurtainOpen" ) then
      fibaro:setGlobal("Sanco3", "CurtainOpen")
      if debug then fibaro:debug("CurtainOpen") end

   elseif ( daytime >= sunrise and currentTime < sunset and Sanco3 ~= "DayTime" ) then
      fibaro:setGlobal("Sanco3", "DayTime")
      if debug then fibaro:debug("DayTime") end   
      
      
      
      --sunset  
    elseif ( curtainclose >= sunset and currentTime > sunset and Sanco3 ~= "CurtainClose" ) then
      fibaro:setGlobal("Sanco3", "CurtainClose");
      if debug then fibaro:debug("CurtainClose"); end
    elseif ( eveningred >= sunset and currentTime > sunset and Sanco3 ~= "EveningRed" ) then
      fibaro:setGlobal("Sanco3", "EveningRed");
      if debug then fibaro:debug("EveningRed"); end
    end
    fibaro:sleep(60*1000);
  end
else
  fibaro:debug("Script can only be run via autostart")
end

the debug order is always starting with sunrise and sunset

 

This scene is changing between daytime and dawn.

First I thought if there is a typo or something wrong he will show the firts value in GV >>>false

[Sjakie 156]

Why he skips "curtainOpen" is wierd

[Sjakie 156]

I think line 35 should be":

  if (dawn >= curtainopen and currentTime < curtainopen and Sanco3 ~= "Dawn" ) then

 

no luck either

[Bodyart 231]

27 minutes ago, Sjakie said:

local curtainopen = os.date("%H:%M", os.time()+15*60)

your definitions are wrong

Please login or register to see this image.

/monthly_2019_04/image.png.6cf91b00e3daee578bb9a89b03299dec.png" />

You don't want to open the curtains @ 17:01, nor close them @ 15:56!

 

Please login or register to see this code.

if (17:36 >= 06:52 and 16:47 < 17:01 DayTime ~= Dawn) then

 

IT IS ALWAYS "Dawn"

Edited April 8, 2019 by Bodyart

[Sjakie 156]

os.date("%H:%M", os.time()+15*60)

is 15 minutes before sunrise

[Bodyart 231]

3 minutes ago, Sjakie said:

os.date("%H:%M", os.time()+15*60)

is 15 minutes before sunrise

nope. it has nothing to do with sunrise

You need to convert the string sunrise to time format and then add your desired difference.

Edited April 8, 2019 by Bodyart

[Sjakie 156]

perhaps you are right If I change in "fixed"times it looks better( I hope)

now I am lost